for f in * ; do mv "$f" $( echo $f | tr ' ' '-' ) ; done

rename old_value replacement_value directory/filename

rename 's/ /-/g' *

As long as you have perl based rename.

You can check:

rename --help

or

rename [-v] [-n] [-f] perlexpr [filenames]